Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module

From: Guenter Roeck
Date: Wed Aug 20 2014 - 16:11:18 EST


On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote:
> Building booke_wdt fails when trying to build as a module as there is no
> early_param() in module. Fix by using module_param() instead of early_param().
>
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> CC: Guenter Roeck <linux@xxxxxxxxxxxx>

Looks good as far as I can see. One question though:

> +MODULE_ALIAS("booke_wdt");

Is this necessary ? If yes, shouldn't it be a separate patch to be applied
to -stable ?

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/