Re: [RFC PATCH 6/9] gpiolib: add API to get gpio desc and flags

From: Grant Likely
Date: Tue Aug 19 2014 - 11:58:36 EST


On Mon, 18 Aug 2014 06:57:41 +0200, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> wrote:
> On Sunday, August 17, 2014 12:43:38 PM Darren Hart wrote:
> > On 8/17/14, 6:00, "Grant Likely" <grant.likely@xxxxxxxxxxxx> wrote:
> >
> > >>
> > >>+ /* Using device tree? */
> > >>+ if (IS_ENABLED(CONFIG_OF) && dev->of_node)
> > >>+ desc = of_find_gpio(dev, NULL, idx, flags);
> > >
> > >of_find_gpio() doesn't exist.
> >
> > Hrm... As of 3.16.0 (e64df3ebe8262c8203d1fe4f541e0241c3112c01)
> >
> > $ git blame -L1455,1456 drivers/gpio/gpiolib.c
> > bae48da2 (Alexandre Courbot 2013-10-17 10:21:38 -0700 1455) static struct
> > gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
> >
> > Have we removed this in -next or something? (on the plane, will verify
> > upon landing)
>
> In 3.17-rc1:
>
> rafael@vostro:~/src/linux-pm> grep -r of_find_gpio *
> drivers/gpio/gpiolib.c:static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
> drivers/gpio/gpiolib.c: desc = of_find_gpio(dev, con_id, idx, &lookupflags);

Weird, I don't know why I couldn't find it. I must have been on a
different branch. Sorry for the noise.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/