Re: [PATCH 4/5] watchdog: control hard lockup detection default

From: Don Zickus
Date: Mon Aug 18 2014 - 11:08:03 EST


On Mon, Aug 18, 2014 at 11:12:39AM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@xxxxxxxxxx> wrote:
>
> > From: Ulrich Obergfell <uobergfe@xxxxxxxxxx>
> >
> > In some cases we don't want hard lockup detection enabled by default.
> > An example is when running as a guest. Introduce
> >
> > watchdog_enable_hardlockup_detector(bool)
>
> So, the name watchdog_enable_hardlockup_detector_enable(false)
> is both too long and also really confusing (because first it
> suggests enablement, then disables it), so I renamed it to
> hardlockup_detector_set(), which allows two natural variants:
>
> hardlockup_detector_set(false);
> ...
> hardlockup_detector_set(true);

Fair enough. Thanks!

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/