Re: [PATCH-REPOST] thermal: of: look for sensor driver parent node if device node missing

From: Eduardo Valentin
Date: Wed Jul 30 2014 - 09:20:30 EST


Laxman,

On Tue, Jul 29, 2014 at 07:53:58PM +0530, Laxman Dewangan wrote:
> On Tuesday 29 July 2014 07:42 PM, Eduardo Valentin wrote:
> > Hello Laxman,
> >
> > On Fri, Jul 25, 2014 at 02:49:31PM +0530, Laxman Dewangan wrote:
> >> There are some mfd devices which supports junction thermal interrupt
> >> like ams,AS3722. The DT binding of these devices are defined as the
> >> flat and drivers for sub module of such devices are registered as
> >> the mfd_add_devices. In this method, the sub devices registered as
> >> platform driver and these do not have the of_node pointer on their
> >> device structure. In this case, use the parent of_node pointer to
> >> get the required of_node pointer.
> >>
> > Can you please elaborate a bit more on your proposal? So, you would
> > append the thermal zones on the DT node of the MFD device?
>
> Yes, mfd node for ams,as3722 is flat node, almost all sub-module driver
> have their property on this node only. Regulator have their own sub node
> under this node.
>
> as3722 {
> compatible = "ams,as3722";
> #gpio-contorller;
> #gpio-cells = <2>;
> ::::::::::
> regulator {
> ::::
> };
> };
>
>
> So in this, the thermal sensor driver's property is on the as3722 node
> only and thermal zone need to refer this node for sensor.
>
> However, as3722 thermal sensor driver is register as sub mfd devices
> through mfd_add_devices() and thermal sensor drivers pdev->dev.of_node
> does not have any valid pointer.

In such case, the MFD driver shall populate the required data while
creating the sub device, right?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/