[PATCH 1/3] dmaengine: sun6i: Remove switch statement from buswidth convertion routine

From: Maxime Ripard
Date: Wed Jul 30 2014 - 04:36:28 EST


Since the conversion routine is quite trivial, we don't need this switch, and
we can just use a simple calculation.

Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
---
drivers/dma/sun6i-dma.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index c771d90b8ded..609c5d8cb947 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -248,20 +248,11 @@ static inline int convert_burst(u32 maxburst, u8 *burst)

static inline int convert_buswidth(enum dma_slave_buswidth addr_width, u8 *width)
{
- switch (addr_width) {
- case DMA_SLAVE_BUSWIDTH_1_BYTE:
- *width = 0;
- break;
- case DMA_SLAVE_BUSWIDTH_2_BYTES:
- *width = 1;
- break;
- case DMA_SLAVE_BUSWIDTH_4_BYTES:
- *width = 2;
- break;
- default:
+ if ((addr_width < DMA_SLAVE_BUSWIDTH_1_BYTE) ||
+ (addr_width > DMA_SLAVE_BUSWIDTH_4_BYTES))
return -EINVAL;
- }

+ *width = addr_width >> 1;
return 0;
}

--
2.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/