Re: vmstat: On demand vmstat workers V8

[Tejun Heo]

On Tue, Jul 29, 2014 at 10:10:11AM -0500, Christoph Lameter wrote:
> On Tue, 29 Jul 2014, Tejun Heo wrote:
> 
> > I agree this can be improved, but at least for now, please add cpu
> > down hooks.  We need them right now and they'll be helpful when later
> > separating out the correctness ones.
> 
> mm/vmstat.c already has cpu down hooks. See vmstat_cpuup_callback().

Hmmm, well, then it's something else.  Either a bug in workqueue or in
the caller.  Given the track record, the latter is more likely.
e.g. it looks kinda suspicious that the work func is cleared after
cancel_delayed_work_sync() is called.  What happens if somebody tries
to schedule it inbetween?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/