Re: [PATCH v2 2/2] pwm: add this patch to support the new pwm of Rockchip SoCs

From: Thierry Reding
Date: Tue Jul 29 2014 - 07:38:21 EST


On Tue, Jul 29, 2014 at 07:09:07PM +0800, caesar wrote:
> Thierry,
>
> å 2014å07æ29æ 18:22, Thierry Reding åé:
> >On Mon, Jul 28, 2014 at 07:19:18PM +0800, caesar wrote:
> >>Doug,
> >>å 2014å07æ28æ 12:01, Doug Anderson åé:
> >>>Caesar,
> >>>
> >>>On Sun, Jul 27, 2014 at 7:00 AM, caesar <caesar.wang@xxxxxxxxxxxxxx> wrote:
> >>>>/*I think will be show the faill log:->
> >>>>
> >>>>* rockchip-pwm ff9301a0.pwm: can't request region for resource [mem
> >>>>0xff9301a0-0xff93019f]
> >>>>*/
> >>>>
> >>>>pc->base = devm_ioremap_resource(dev, regs);
> >>>Did you actually code this up and try it and get this error?
> >>Yeah.
> >This should work if you properly set up the PWM subregion as a child of
> >the LCDC region, which is what MFD will do for you.
> >
> >Thierry
> As you say,should this change be occured by lcdc driver and dts?
>
> The PWM driver don't need do any changes?

No, I don't think the PWM driver needs to be changed for the above to
work.

Thierry

Attachment: pgpt1zTz5logN.pgp
Description: PGP signature