Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

From: Peter Zijlstra
Date: Mon Jul 28 2014 - 12:57:49 EST


On Mon, Jul 28, 2014 at 09:53:58AM -0700, Davidlohr Bueso wrote:
> Well, it's not hard to see where the contention is when working on
> locking issues with perf. With mutexes there are only two sources,
> either the task is just spinning trying to get the lock, or its gone to
> the slowpath, and you can see a lot of contention on the wait_lock.
>
> So unless I'm missing something, I don't think we'd need to make this
> noinline again -- although I forget why it was changed in the first
> place.

Not to mention that there's no actual caller of this function in the
entire kernel ;-) Currently its just 'documentation' describing what an
actual MCS lock looks like.

Attachment: pgpmEuC0hL6M_.pgp
Description: PGP signature