Re: [PATCH] s390: block: dasd_devmap.c: Cleaning up missing null-terminate in conjunction with strncpy

[Jeff Moyer]

Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> writes:

> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/s390/block/dasd_devmap.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/block/dasd_devmap.c b/drivers/s390/block/dasd_devmap.c
> index 2ead7e7..4a60ef8 100644
> --- a/drivers/s390/block/dasd_devmap.c
> +++ b/drivers/s390/block/dasd_devmap.c
> @@ -424,7 +424,7 @@ dasd_add_busid(const char *bus_id, int features)
>  	if (!devmap) {
>  		/* This bus_id is new. */
>  		new->devindex = dasd_max_devindex++;
> -		strncpy(new->bus_id, bus_id, DASD_BUS_ID_SIZE);
> +		strlcpy(new->bus_id, bus_id, DASD_BUS_ID_SIZE);

NACK

kzalloc'd.

Did you put thought into *any* of these conversions?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/