Re: [PATCH v2 2/2] pwm: add this patch to support the new pwm of Rockchip SoCs

From: caesar
Date: Mon Jul 28 2014 - 07:19:35 EST


Doug,
å 2014å07æ28æ 12:01, Doug Anderson åé:
Caesar,

On Sun, Jul 27, 2014 at 7:00 AM, caesar <caesar.wang@xxxxxxxxxxxxxx> wrote:
/*I think will be show the faill log:->

* rockchip-pwm ff9301a0.pwm: can't request region for resource [mem
0xff9301a0-0xff93019f]
*/

pc->base = devm_ioremap_resource(dev, regs);
Did you actually code this up and try it and get this error?
Yeah.
I hadn't
tried it but I researched other dts files and it looked as if there
was one example that was doing this. ...but perhaps it wasn't
actually doing the ioremap_resource on both ranges.

I'd imagine that this is _probably_ equivalent to what Thierry was
suggesting, so if it didn't work then maybe Thierry's won't work
either?

I don't have any other great suggestions other than doing two memory
ranges for lcdc:

lcdc@ff930000 {
compatible = "rockchip,rk3288-lcdc";
reg = <0xff930000 0x1a0>, <0xff9301b0 0xfe50>;
...
};
pwm@ff9301a0 {
compatible = "rockchip,vop-pwm";
reg = <0xff9301a0 0x10>;
...
};

...but I am certainly nowhere near an expert on this stuff...

-Doug



I has solve in lcdc driver,but I always feel awkward. I think a good way to solve in pwm driver.
Unfortunately that so far ,I have not a good idle in pwm driver.

Maybe,I let do it that way in lcdc driver.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/