Re: [PATCH v3 6/9] perf, x86: handle multiple records in PEBS buffer

[Andi Kleen]

> I don't think this method works for interrupt threshold > 1 case. When collision
> happens, the hardware only create one PEBS record. The status in next record has
> nothing to do with the collision record.
>
Not even for the threshold == 1 case, because the same could happen with
a different PEBS event. Of course in any case it's very unlikely ...

 > 
> > So typically we'd have one event set and no problem, but in case there's
> > more we can reconstruct with such a backwards pass from a known good
> > state.
> > 
> > But when in doubt, we should drop the record, its the safest choice.
> 
> The problem is that, in some cases, each PEBS record has more than one events
> set, so we will drop all records.

Just dropping is fine imho, this should be rare.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/