Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c

[Nick Krause]

On Tue, Jul 22, 2014 at 1:25 PM, Tony Luck <tony.luck@xxxxxxxxx> wrote:
> On Tue, Jul 22, 2014 at 7:04 AM, BjÃrn Mork <bjorn@xxxxxxx> wrote:
>>> -     /* FIXME - should use PAGE_SHIFT */
>>> -     page = error_1b >> 6;   /* convert the address to 4k page */
>>> +     page = error_1b >> PAGE_SHIFT;  /* convert the address to 4k page */
>>
>> I just have to bite...  Where did you get the idea that you can go
>> around and "fix" FIMXE's like they were spelling errors?
>
> Or apparently without thinking? Since "PAGE_SHIFT" does not have
> the numerical value "6" your new code is obviously not equivalent to
> the old.
>
> -Tony

Tony,

What is the value of Page shift then ? If you can tell me it would be
much easier for
me to fix this.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/