Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags()

From: Tejun Heo
Date: Tue Jul 22 2014 - 10:38:33 EST


On Tue, Jul 22, 2014 at 01:02:00PM +0800, Lai Jiangshan wrote:
> worker_set_flags() doesn't necessarily wake next worker and the @wakeup
> can be removed, the caller can use the following conbination instead
> when needed:
>
> worker_set_flags();
> if (need_more_worker(pool))
> wake_up_worker(pool);
>
> It reduces the machine-code and footprint for the process_one_work()
> if worker_set_flags() is really inlined.
>
> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>

Applied 1-2 to wq/for-3.17 w/ descriptions and comments updated.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/