[PATCH] video: fbdev: valkyriefb.c: Cleaning up variable that is never used

From: Rickard Strandqvist
Date: Sat Jul 05 2014 - 08:51:12 EST


From: Rickard Strandqvist <rickard.strandqvist@xxxxxxxxxxxxxx>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
---
drivers/video/fbdev/valkyriefb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 97cb9bd..af708fe 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -416,18 +416,18 @@ static int read_valkyrie_sense(struct fb_info_valkyrie *p)

out_8(&p->valkyrie_regs->msense.r, 0); /* release all lines */
__delay(20000);
- sense = ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4;
+ sense = ((in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4;
/* drive each sense line low in turn and collect the other 2 */
out_8(&p->valkyrie_regs->msense.r, 4); /* drive A low */
__delay(20000);
- sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x30);
+ sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x30);
out_8(&p->valkyrie_regs->msense.r, 2); /* drive B low */
__delay(20000);
sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x40) >> 3;
sense |= (in & 0x10) >> 2;
out_8(&p->valkyrie_regs->msense.r, 1); /* drive C low */
__delay(20000);
- sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5;
+ sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5;

out_8(&p->valkyrie_regs->msense.r, 7);

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/