Re: [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111)

From: Linus Torvalds
Date: Thu Jul 03 2014 - 11:42:06 EST


On Thu, Jul 3, 2014 at 6:02 AM, Raghavendra K T
<raghavendra.kt@xxxxxxxxxxxxxxxxxx> wrote:
>
> However it broke sys_readahead semantics: 'readahead() blocks until the specified
> data has been read'

What? Where did you find that insane sentence? And where did you find
an application that depends on that totally insane semantics that sure
as hell was never intentional.

If this comes from some man-page, then the man-page is just full of
sh*t, and is being crazy. The whole and *only* point of readahead() is
that it does *not* block, and you can do it across multiple files.

So NAK NAK NAK. This is insane and completely wrong. And the bugzilla
is crazy too. Why would anybody think that readahead() is the same as
read()?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/