Re: Crash on WRITE SAME

From: Mikulas Patocka
Date: Wed Jul 02 2014 - 14:29:58 EST




On Wed, 2 Jul 2014, Christoph Hellwig wrote:

> On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote:
> > Hi Sagi
> >
> > Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI
> > WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl).
> > The crash happens in iscsi_tcp_segment_done because sg_next returns NULL.
>
> Martin already fixes this over a week ago, we're just waiting for James
> to send a pull request to Linus.
>
> Get this fix from the core-for-3.16 branch of
> git.infradead.org/users/hch/scsi-queue.git for now.

I see.

And what about protection information for commands that transfer partial
sectors? (for example, UMAP transfers 24 bytes). Should
scsi_transfer_length return 24 or 32 in this case?

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/