Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

From: Mark Brown
Date: Wed Jul 02 2014 - 07:17:14 EST


On Wed, Jul 02, 2014 at 06:57:46PM +0800, Jianqun wrote:
> Hi Mark:

Don't top post.

> Since regmap_update_bits is int style, I have to error check every time after call it.
> Also I find that the tegra_i2s.c call the function without error checking,

> Could you tell me the right way to handle the regmap_update_bits ?

With memory mapped I/O there's no real point in checking for errors so
if you kno0w your device is memory mapped you can get away with just
ignoring them.

Attachment: signature.asc
Description: Digital signature