Re: [PATCH 3/3] perf tools: Add ui.show-headers config file option

From: Jiri Olsa
Date: Mon Jun 30 2014 - 14:07:54 EST


On Mon, Jun 30, 2014 at 08:13:24PM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> 2014-06-27 (ê), 18:26 +0200, Jiri Olsa:
> > Adding report.show-headers config file option to setup
> > the appearance of the columns headers.
> >
> > Currently columns headers are displayed by default, following
> > lines in ~/.perfconfig file will disable that:
> >
> > [ui]
> > show-headers = true
>
> s/true/false/ :)

ouch ;-)

>
> I'm afraid that we might need to add some code to show/hide column
> headers for stdio and GTK too..
>
>
> >
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> > Cc: David Ahern <dsahern@xxxxxxxxx>
> > Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> Anyway, with above typo fixed, patches look good!
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/