Re: [PATCH 1/2] zram: use size_t instead of u16

From: Sergey Senozhatsky
Date: Mon Jun 30 2014 - 05:47:15 EST


On (06/30/14 11:54), Minchan Kim wrote:
> Date: Mon, 30 Jun 2014 11:54:38 +0900
> From: Minchan Kim <minchan@xxxxxxxxxx>
> To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx, Sergey Senozhatsky
> <sergey.senozhatsky@xxxxxxxxx>, Weijie Yang <weijie.yang@xxxxxxxxxxx>,
> Jerome Marchand <jmarchan@xxxxxxxxxx>, Nitin Gupta <ngupta@xxxxxxxxxx>,
> Minchan Kim <minchan@xxxxxxxxxx>
> Subject: [PATCH 1/2] zram: use size_t instead of u16
> X-Mailer: git-send-email 2.0.0
>
> Some of arch(ex, hexagon and PowerPC) could use PAGE_SHIFT
> as 16 above. In the case, u16 is is lack of representing
> compressed page's size so use size_t.
>
> Reported-by: Weijie Yang <weijie.yang@xxxxxxxxxxx>
> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

-ss

> ---
> drivers/block/zram/zram_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 089e72cd37be..3233bccd6361 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -337,7 +337,7 @@ static int zram_decompress_page(struct zram *zram, char *mem, u32 index)
> unsigned char *cmem;
> struct zram_meta *meta = zram->meta;
> unsigned long handle;
> - u16 size;
> + size_t size;
>
> read_lock(&meta->tb_lock);
> handle = meta->table[index].handle;
> --
> 2.0.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/