Re: [RFC PATCH] bio-integrity: add "bip_max_vcnt" into struct bio_integrity_payload
From: Martin K. Petersen
Date: Sun Jun 29 2014 - 19:16:20 EST
>>>>> "Gu" == Gu Zheng <guz.fnst@xxxxxxxxxxxxxx> writes:
[Sorry about the delay. I'm on vacation right now.]
Gu> But it seems that bip_integrity_vecs() will return the wrong number
Gu> if the bio is not based on any bio_set for some reason(bio->bi_pool
Gu> == NULL), because in that case, the bip_inline_vecs[0] is malloced
Gu> directly. So here we add the bip_max_vcnt to record the count of
Gu> vector slots, and cleanup the function bip_integrity_vecs().
I'm in agreement with your fix.
However, I'm still not sure what the use case is for bios without an
associated bioset. I do not see any callers that pass in a NULL bioset.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/