Re: lib/argv_split.c : should argv be kfree'ed ?

From: Mateusz Guzik
Date: Sat Jun 28 2014 - 18:04:45 EST


On Sat, Jun 28, 2014 at 11:52:37PM +0200, Toralf FÃrster wrote:
> /me wonders if this patch is needed here :
>
>
> diff --git a/lib/argv_split.c b/lib/argv_split.c
> index e927ed0..7de4cb4 100644
> --- a/lib/argv_split.c
> +++ b/lib/argv_split.c
> @@ -85,6 +85,7 @@ char **argv_split(gfp_t gfp, const char *str, int *argcp)
> *argv++ = argv_str;
> }
> }
> + kfree (argv);
> *argv = NULL;
>
> if (argcp)
>

No, see argv_free.

--
Mateusz Guzik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/