Re: [PATCHSET block/for-next] blk-mq: update freezing

From: Jens Axboe
Date: Sat Jun 28 2014 - 10:29:39 EST


On 2014-06-28 06:13, Tejun Heo wrote:
On Wed, Jun 18, 2014 at 09:19:26AM -0700, Jens Axboe wrote:
percpu/for-3.17 6fbc07bbe2b5 ("percpu: invoke __verify_pcpu_ptr() from the generic part of accessors and operations")
+[1] [PATCHSET percpu/for-3.17] percpu: implement percpu_ref_reinit()

and available in the following git branch.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git review-mq-percpu_ref

block/blk-core.c | 13 ++++---
block/blk-mq.c | 90 ++++++++++++++++---------------------------------
block/blk-mq.h | 2 -
block/blk-sysfs.c | 2 -
include/linux/blkdev.h | 4 +-
5 files changed, 44 insertions(+), 67 deletions(-)

Thanks Tejun, this looks pretty good. I was worried the tryget_live() would
be too expensive, but that looks not to be the case. I like the cleanups to
using a general mechanism. I'll run this through some functional and
performance testing.

FYI, the percpu_ref changes needed by this patchset are applied to
percpu/for-3.17 branch which is stable and can be pulled into the
block tree.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-3.17

Great, thanks! Was just mulling over this yesterday. I'll get it pulled in as a base.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/