Re: [PATCH -repost 05/21] kgr: update Kconfig documentation

[Jiri Slaby]

On 06/25/2014 02:42 PM, One Thousand Gnomes wrote:
> On Wed, 25 Jun 2014 13:06:59 +0200
> Jiri Slaby <jslaby@xxxxxxx> wrote:
> 
>> This is based on Udo's text which was augmented in this patch.
>>
>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
>> Cc: Udo Seidel <udoseidel@xxxxxx>
>> Cc: Vojtech Pavlik <vojtech@xxxxxxx>
>> ---
>>  kernel/Kconfig.kgraft | 3 +++
>>  samples/Kconfig       | 4 ++++
>>  2 files changed, 7 insertions(+)
>>
>> diff --git a/kernel/Kconfig.kgraft b/kernel/Kconfig.kgraft
>> index f38d82c06580..bead93646071 100644
>> --- a/kernel/Kconfig.kgraft
>> +++ b/kernel/Kconfig.kgraft
>> @@ -5,3 +5,6 @@ config KGRAFT
>>  	bool "kGraft infrastructure"
>>  	depends on DYNAMIC_FTRACE_WITH_REGS
>>  	depends on HAVE_KGRAFT
>> +	help
>> +	  Select this to enable kGraft online kernel patching. The
>> +	  runtime price is zero, so it is safe to say Y here.
>> diff --git a/samples/Kconfig b/samples/Kconfi
> 
> The runtime impact is that you've just introduced a virus and trojan
> writers delight into your kernel. There's a balance between convenience
> and security but given most users will never use kgraft this advice seems
> incorrect.

This now writes:
+       help
+         Select this to enable kGraft online kernel patching. The
+         runtime price is nearly zero, so it is safe to say Y here
+         provided you are aware of all the consequences (e.g. in
+         security).

Is it OK with you?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/