Re: [PATCH] scripts/checkpatch.pl: Only emit LONG_LINE for --strict

From: Josh Triplett
Date: Thu Jun 26 2014 - 01:50:04 EST


On Wed, Jun 25, 2014 at 10:29:30PM -0700, Joe Perches wrote:
> On Wed, 2014-06-25 at 22:08 -0700, Josh Triplett wrote:
>
> > Now, arguably the four leading tabs on those lines suggest the need for
> > some code refactoring; personally, I'd suggest changing DEEP_INDENTATION
> > to flag 4+ tabs rather than 6+ tabs as it currently does.
>
> There are _way too many_ 4+ tab indents for that to
> be sensible.

Yeah, a quick grep confirmed that. On the other hand, if *already*
flagging a long line, it makes sense to flag 4+ tabs as potentially
excessive nesting.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/