Re: [PATCH] arm/arm64: DT: Fix GICv2 CPU interface size

From: Marc Zyngier
Date: Wed Jun 25 2014 - 08:33:12 EST


On Wed, Jun 25 2014 at 01:21:17 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> On Wed, Jun 25, 2014 at 5:37 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
>> All the Cortex-{A7,A15} implementations are using a GICv2. Same for
>> the current arm64 platforms.
>>
>> Turns out that most of these platforms have described their GIC CPU
>> interface size as being 4kB. while it is actually 8kB (the GICC_DIR
>> register lives at offset 0x1000).
>>
>> This was found when converting the GIC driver to use EOImode==1 on
>> GICv2-based systems. It uses the GICC_DIR register, and the result
>> is a very early firework...
>
> What's your plan for making the kernel change? Updating the dts files
> is good, but that doesn't immediately help you if you have old dtbs.

See at the end of https://lkml.org/lkml/2014/6/25/243

Basically, we stay with a GICv1 behaviour if we detect the mess.

>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>> ---
>> arch/arm/boot/dts/axm55xx.dtsi | 2 +-
>> arch/arm/boot/dts/dra7.dtsi | 2 +-
>> arch/arm/boot/dts/ecx-2000.dts | 2 +-
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Thanks,

M.
--
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/