Re: [PATCH 1/7] sched,numa: use group's max nid as task's preferred nid

From: Mel Gorman
Date: Wed Jun 25 2014 - 06:32:03 EST


On Mon, Jun 23, 2014 at 11:41:29AM -0400, riel@xxxxxxxxxx wrote:
> From: Rik van Riel <riel@xxxxxxxxxx>
>
> From task_numa_placement, always try to consolidate the tasks
> in a group on the group's top nid.
>
> In case this task is part of a group that is interleaved over
> multiple nodes, task_numa_migrate will set the task's preferred
> nid to the best node it could find for the task, so this patch
> will cause at most one run through task_numa_migrate.
>
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>

That loop was written prior to pseudo-interleaving as well and in the
context of that change this makes sense and removes a potentially
expensive loop.

Acked-by: Mel Gorman <mgorman@xxxxxxx>

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/