Re: [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range()

[Vlastimil Babka]

On 06/24/2014 06:58 PM, Naoya Horiguchi wrote:
> On Tue, Jun 24, 2014 at 05:34:32PM +0200, Vlastimil Babka wrote:
> > On 06/24/2014 06:52 AM, Naoya Horiguchi wrote:
> > > > -	low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn, false);
> > > > -	if (!low_pfn || cc->contended)
> > > > -		return ISOLATE_ABORT;
> > > > +		/* Do not scan within a memory hole */
> > > > +		if (!pfn_valid(low_pfn))
> > > > +			continue;
> > > > +
> > > > +		page = pfn_to_page(low_pfn);
> > >
> > > Can we move (page_zone != zone) check here as isolate_freepages() does?
> >
> > Duplicate perhaps, not sure about move.
>
> Sorry for my unclearness.
> I meant that we had better do this check in per-pageblock loop (as the free
> scanner does) instead of in per-pfn loop (as we do now.)

Hm I see, the migration and free scanners really do this differently. 
Free scanned per-pageblock, but migration scanner per-page.
Can we assume that zones will never overlap within a single pageblock?
The example dc9086004 seems to be overlapping at even higher alignment 
so it should be safe only to check first page in pageblock.
And if it wasn't the case, then I guess the freepage scanner would 
already hit some errors on such system?

But if that's true, why does page_is_buddy test if pages are in the same 
zone?

> > Does CMA make sure that all pages
> > are in the same zone?
>
> It seems not, CMA just specifies start pfn and end pfn, so it can cover
> multiple zones.
> And we also have a case of node overlapping as commented in commit dc9086004
> "mm: compaction: check for overlapping nodes during isolation for migration".
> So we need this check in compaction side.
>
> Thanks,
> Naoya Horiguchi
>
> > Common sense tells me it would be useless otherwise,
> > but I haven't checked if we can rely on it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/