Re: [PATCH 1/2] regulator: max1586 add device-tree support

[Mark Brown]

On Tue, Jun 24, 2014 at 08:05:30PM +0200, Robert Jarzmik wrote:
> Mark Brown <broonie@xxxxxxxxxx> writes:

> >> As for the "state report", this max1586 doesn't report anything, it cannot even
> >> be queried about the current voltage, sic ...

> > It can't?  That's unfortunate, though I was able to turn up a datasheet
> > which appears to support that.

> Oh really ? Well, tell me where you read it.

I said I *was* able to turn up a datasheet which appeared to support
that.

> >> If you want me to modify this bit I need a bit more of an explanation to
> >> understand.

> > Where the driver is doing unusual things if they are actually sensible
> > then the change needs to be clearer about why.

> So would a comment like this address your comment ?

> 	/* Either matched < 0 and return the error. Or matched is 0 which means
> 	 * no init data was found, ie. no regulator is configured, and return 0
> 	 * to caller, stating neither error nor any matched regulator.
> 	 */
> 	if (matched <= 0)
> 		return matched;

Can you include something like "...and we have no readback support in
the device so can't report status" or something please?  That's the key
bit - the point is that even unconfigured regulators should normally be
registered.

Attachment: signature.asc
Description: Digital signature