Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

From: Linus Walleij
Date: Thu Jun 12 2014 - 03:49:31 EST


On Wed, Jun 4, 2014 at 12:25 AM, <eric.ernst@xxxxxxxxxxxxxxx> wrote:

> From: Eric Ernst <eric.ernst@xxxxxxxxxxxxxxx>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode. When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst <eric.ernst@xxxxxxxxxxxxxxx>

This does not apply to my devel branch or Torvald's HEAD.
Please rebase and repost, and include Mika's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/