Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages

From: Dan Carpenter
Date: Wed Jun 11 2014 - 03:49:27 EST


Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

This check introduces 1849 new checkpatch.pl warnings. I looked through
the first 70 warnings and there were no false positives.

Besides the bloat issue, I don't like these warnings because they make
the error handling harder to read. They are sort of a mindless thing
that people feel they have to do for no particular reason. Since
people aren't thinking when they write the error message then you get
NULL dereferences and so on.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/