Re: [patch V3 7/7] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk

[Steven Rostedt]

On Tue, 10 Jun 2014 19:43:16 +0200 (CEST)
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Tue, 10 Jun 2014, Steven Rostedt wrote:
> 
> > On Tue, 10 Jun 2014 09:57:25 -0500
> > "Brad Mouring" <bmouring@xxxxxx> wrote:
> > 
> > 
> > > > +		/* Store whether owner is blocked itself and drop locks */
> > > > +		next_lock = task_blocked_on(task);
> > > task_blocked_on(task) is not clear to me, the recipient of the
> > > return is the only clue that hints at what the function does.
> > 
> > Well, this is more than confusing, it's the only user, all other users
> > are task_blocked_on_lock(), and this causes the code not to compile.
> 
> Grr, yes.

Luckily you are not posting this to that grumpy IRQ maintainer. He'd
shoot some frozen sharks your way if you sent him patches like this ;-)

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/