Re: [PATCH 6/7] lib/random32.c: Randomize timeout to the millisecond, not the second

[George Spelvin]

> Fine by me this cleanup, although not strictly needed.

Agreed.  The timer slack is set to HZ (1 second) anyway.

It just dawned on me that a simpler and more efficient way to do this
(which I'll do in v2 of this) would be:

   	/* reseed every ~60 seconds, in [40 .. 80) interval with slack */
-	expires = 40 + (prandom_u32() % 40);
-	seed_timer.expires = jiffies + msecs_to_jiffies(expires * MSEC_PER_SEC);
+	expires = 40*HZ + prandom_u32_max(40*HZ);
+	seed_timer.expires = jiffies + expires;

That avoids calling msecs_to_jiffies entirely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/