Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

[eric ernst]

On 14-05-30 01:48 AM, Mika Westerberg wrote:
> On Tue, May 27, 2014 at 12:26:44PM -0700, eric.ernst@xxxxxxxxxxxxxxx wrote:
> > From: Eric Ernst <eric.ernst@xxxxxxxxxxxxxxx>
> >
> > For Baytrail, you should never set a GPIO set to direct_irq
> > to output mode.  When direct_irq_en is set for a GPIO, it is
> > tied directly to an APIC internally, and making the pad output
> > does not make any sense. Assert a WARN() in the event this happens.
> Can't we just clear that flag when the GPIO is requested? Or is this
> something which can't be done at this point?
The IRQ setting for that register (the IRQ wiring via direct_irq_en) 
should be set statically on boot, and should not be changed, let alone 
allowing for multiple changes during runtime.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/