Re: [PATCH RFC - TAKE TWO - 06/12] block, bfq: improve responsiveness

[Tejun Heo]

On Thu, May 29, 2014 at 11:05:37AM +0200, Paolo Valente wrote:
> @@ -281,7 +323,8 @@ static inline unsigned long bfq_serv_to_charge(struct request *rq,
>  					       struct bfq_queue *bfqq)
>  {
>  	return blk_rq_sectors(rq) *
> -		(1 + ((!bfq_bfqq_sync(bfqq)) * bfq_async_charge_factor));
> +		(1 + ((!bfq_bfqq_sync(bfqq)) * (bfqq->wr_coeff == 1) *
> +		bfq_async_charge_factor));

Ah, okay, so you actually use it later.  Please disregard my previous
comment about dropping the wrapper.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/