Re: [PATCH v4] NVMe: basic conversion to blk-mq

[Matthew Wilcox]

On Thu, May 29, 2014 at 11:51:25PM +0200, Matias Bjørling wrote:
> @@ -816,9 +671,7 @@ static irqreturn_t nvme_irq(int irq, void *data)
>  	irqreturn_t result;
>  	struct nvme_queue *nvmeq = data;
>  	spin_lock(&nvmeq->q_lock);
> -	nvme_process_cq(nvmeq);
> -	result = nvmeq->cqe_seen ? IRQ_HANDLED : IRQ_NONE;
> -	nvmeq->cqe_seen = 0;
> +	result = nvme_process_cq(nvmeq) ? IRQ_HANDLED : IRQ_NONE;
>  	spin_unlock(&nvmeq->q_lock);
>  	return result;
>  }

Put cqe_seen back.  I already told Sam this was wrong.
http://lists.infradead.org/pipermail/linux-nvme/2014-May/000856.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/