Re: [PATCH] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices

From: Wolfram Sang
Date: Fri May 30 2014 - 08:37:36 EST


On Fri, May 30, 2014 at 01:26:36PM +0100, Lee Jones wrote:
> Currently the I2C framework insists on devices supplying an I2C ID
> table. Many of the devices which do so unnecessarily adding quite a
> few wasted lines to kernel code. This patch allows drivers a means
> to 'not' supply the aforementioned table and match on either DT
> and/or ACPI match tables instead.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Sadly, it is not that easy...

> + /*
> + * An I2C ID table is not madatory, if and only if, a suitable Device
> + * Tree and/or ACPI match table entry is supplied for the probing
> + * device.
> + */

That means we end up with drivers which cannot be used for run-time
instantiation via the 'new_device'-file in sysfs. I don't like that.

Attachment: signature.asc
Description: Digital signature