Re: Extend irq_set_affinity_notifier() to use a call chain

From: Thomas Gleixner
Date: Tue May 27 2014 - 06:10:29 EST


On Tue, 27 May 2014, Amir Vadai wrote:
> On 5/26/2014 3:39 PM, Thomas Gleixner wrote:
> > Even if you'd solve that and have a callback in the driver, then the
> > callback never can restart the napi session directly. All it can do is
> > set a flag which needs to be checked in the RX path, right?
> >
> > So what's the point of adding notifier call chain complexity, ordering
> > problems etc., if you can simply note the fact that the affinity
> > changed in the rmap itself and check that in the RX path?
>
> I will try to find a solution in the spirit of what you suggested -
> to let the rmap library notify napi about affinity changes - without
> adding this complexity to the code.

I'd rather avoid the term "notify". Because it's not an active
notification which results in an immediate NAPI restart. NAPI has to
poll the information in rmap or wherever you end up storing it.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/