RE: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator

From: Yibin Gong
Date: Mon May 26 2014 - 23:05:59 EST


Tested-by: Robin Gong <b38343@xxxxxxxxxxxxx>
Acked-by: Robin Gong <b38343@xxxxxxxxxxxxx>

-----Original Message-----
From: Axel Lin [mailto:axel.lin@xxxxxxxxxx]
Sent: Monday, May 26, 2014 5:56 PM
To: Mark Brown
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Liam Girdwood; linux-kernel@xxxxxxxxxxxxxxx
Subject: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator

Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel

drivers/regulator/pfuze100-regulator.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 67e678c..b6b4529 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = { };

static struct regulator_ops pfuze100_fixed_regulator_ops = {
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .is_enabled = regulator_is_enabled_regmap,
.list_voltage = regulator_list_voltage_linear, };

--
1.8.3.2