Re: [PATCH v3 06/13] mmc: mmci: Qcomm: Add 3 clock cycle delay after register write

From: Srinivas Kandagatla
Date: Mon May 26 2014 - 13:04:42 EST




I am not sure I like this approach. For each and every writel
(including pio_writes) you will add a few cpu cycles, since you need
to check for "mclk_delayed_writes" no matter of variant.


How about, adding a new function pointer in the struct mmci_host, for
"writel operations" which you could set up in probe phase instead?


Yes, this is an additional check for other variants. I will try the function pointer method that you suggested.

Thanks,
srini


Kind regards
Ulf Hansson

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/