Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog

[Michael Brunner]

On Thu, 24 Apr 2014 08:15:40 -0700, Guenter Roeck <linux@xxxxxxxxxxxx>
wrote:
> On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote:
> > Use the prescaler index, rather than its value, to configure the
> > watchdog. This will prevent a mismatch with the prescaler used to
> > calculate the cycles.
> > 
> > Signed-off-by: Per Gundberg <per.gundberg@xxxxxxxxxxx>
> 
> Good catch. Looks correct to me. Michael, any comments ?
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Setting the prescaler incorrectly this way can cause the system to
reboot nearly immediately when activating the watchdog - not good.
This should also be applied to the stable revisions as this code is
included since 3.11.

Reviewed-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
Tested-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>

Thanks,
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/