Re: [PATCH] Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h

From: Joe Perches
Date: Wed May 07 2014 - 15:43:40 EST


On Tue, 2014-05-06 at 14:54 +0530, Sheetal Tigadoli wrote:
> This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' &
> 'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h

This is poor patch subject style.
Please use "[PATCH] subsystem: description" style.

> This patch is sent to complete one of Eudyptula Challenges

Please do not include any "Eudyptula Challenge" line
in the commit log.

> diff --git a/drivers/staging/comedi/drivers/das08.h b/drivers/staging/comedi/drivers/das08.h
[]
> @@ -50,7 +49,8 @@ struct das08_board_struct {
> struct i8254_struct {
> - int channels; /* available channels. Some could be used internally. */
> + int channels; /* available channels. Some could be used
> + internally. */

Multiline comment style should use
/*
* comment lines
* ...
*/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/