Re: fs: dcookie: freeing active timer

From: Thomas Gleixner
Date: Tue May 06 2014 - 08:31:44 EST


On Mon, 5 May 2014, Andrew Morton wrote:

> On Mon, 05 May 2014 16:44:34 -0400 Sasha Levin <sasha.levin@xxxxxxxxxx> wrote:
>
> > On 05/01/2014 04:10 PM, Andrew Morton wrote:
> > >> On Wed, 30 Apr 2014, Sasha Levin wrote:
> > >> >
> > >>>> > > > Could someone pretty please merge that patch? Specially since Greg acked it?
> > >>> > >
> > >>> > > Ping?
> > >> >
> > >> > Ok please repost. Andrew or Pekka can merge it.
> > > OK, I seem to have pieced it all together. The changelog sucked :( I
> > > fixed it up a bit but I still don't see why we added that
> > > SLAB_SUPPORTS_SYSFS thing. Why do slab and slub differ here? What
> > > about slob?
> > >
> > > A number of rejects had to be fixed. Please check this over carefully.
> >
> > That patch fixed the issues I've been seeing, and I'm not seeing any new
> > issues caused by the patch.
>
> OK, thanks. That patch was busted with CONFIG_SYSFS=n and I ended up
> moving things around quite a bit to fix that. The new version is
> below.
>
> I'll queue this for 3.15 but not for -stable: I don't think we care a
> lot about debugobjects warnings in stable kernels?

If debugobjects warns you about freeing an active timer, then you
better care. With debugobjects disabled the kernel will just crash in
the timer softirq or explode somewhere else.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/