Re: [PATCH 2/2] kernel/cpuset.c: convert printk to pr_foo()

From: Li Zefan
Date: Mon May 05 2014 - 21:23:21 EST


On 2014/5/6 1:49, Fabian Frederick wrote:
> Cc: Li Zefan <lizefan@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

Acked-by: Li Zefan <lizefan@xxxxxxxxxx>

> ---
> kernel/cpuset.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index 1d8c047..7c0e8da 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -696,11 +696,8 @@ restart:
> if (nslot == ndoms) {
> static int warnings = 10;
> if (warnings) {
> - printk(KERN_WARNING
> - "rebuild_sched_domains confused:"
> - " nslot %d, ndoms %d, csn %d, i %d,"
> - " apn %d\n",
> - nslot, ndoms, csn, i, apn);
> + pr_warn("rebuild_sched_domains confused: nslot %d, ndoms %d, csn %d, i %d, apn %d\n",
> + nslot, ndoms, csn, i, apn);
> warnings--;
> }
> continue;
> @@ -2018,7 +2015,7 @@ static void remove_tasks_in_empty_cpuset(struct cpuset *cs)
> parent = parent_cs(parent);
>
> if (cgroup_transfer_tasks(parent->css.cgroup, cs->css.cgroup)) {
> - printk(KERN_ERR "cpuset: failed to transfer tasks out of empty cpuset ");
> + pr_err("cpuset: failed to transfer tasks out of empty cpuset ");
> pr_cont_cgroup_name(cs->css.cgroup);
> pr_cont("\n");
> }
> @@ -2555,7 +2552,7 @@ void cpuset_print_task_mems_allowed(struct task_struct *tsk)
> cgrp = task_cs(tsk)->css.cgroup;
> nodelist_scnprintf(cpuset_nodelist, CPUSET_NODELIST_LEN,
> tsk->mems_allowed);
> - printk(KERN_INFO "%s cpuset=", tsk->comm);
> + pr_info("%s cpuset=", tsk->comm);
> pr_cont_cgroup_name(cgrp);
> pr_cont(" mems_allowed=%s\n", cpuset_nodelist);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/