RE: [PATCH v2] x86/mce: Improve mcheck_init_device() error handling

From: Luck, Tony
Date: Mon May 05 2014 - 19:29:23 EST


+err_device_create:
+ /*
+ * mce_device_remove behave properly if mce_device_create was not
+ * called on that device.
+ */
+ for_each_possible_cpu(i)
+ mce_device_remove(i);

grammar comment "s/behave/behaves/"

Though perhaps this is better:

/*
* We didn't keep track of which devices were created above, but
* even if we had, the set of online cpus might have changed.
* Play safe and remove for every possible cpu since mce_device_remove()
* will do the right thing.
*/

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/