Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions.

From: Peter Zijlstra
Date: Thu May 01 2014 - 05:31:54 EST


On Thu, May 01, 2014 at 07:26:05PM +1000, NeilBrown wrote:
> On Thu, 1 May 2014 09:42:57 +0200 Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > On Thu, May 01, 2014 at 12:37:38PM +1000, NeilBrown wrote:
> > > +static inline int
> > > +wait_on_bit(void *word, int bit, unsigned mode)
> > > +{
> > > + if (!test_bit(bit, word))
> > > + return 0;
> > > + return out_of_line_wait_on_bit(word, bit,
> > > + bit_wait,
> > > + mode & 65535);
> > > +}
> >
> > Still puzzled by the 16 bit mask there ;-)
>
> I clearly remember removing that!
> And I've just done it again.
> I hope it doesn't re-reappear!
> :-)
> NeilBrown

Seems dead now, I'll hold out for a little while so that dhowells can
explain this fscache thing.

Then I'll queue it. Ingo is currently enjoying a long weekend and is
fighting (well I am now) a stability issue in -tip kernels, so it might
be a little while before it actually shows up in the git tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/