Re: [PATCH v4 4/5] x86: log error on secondary CPU wakeup failure at ERR level

[Toshi Kani]

On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote:
> If system is running without debug level logging,
> it will not log error if do_boot_cpu() failed to
> wakeup AP. It may lead to silent AP bringup
> failures at boot time.
> Change message level to KERN_ERR to make error
> visible to user as it's done on other architectures.
> 
> Signed-off-by: Igor Mammedov <imammedo@xxxxxxxxxx>
> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 2988f69..ae2fd97 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -918,7 +918,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle)
>  
>  	err = do_boot_cpu(apicid, cpu, tidle);
>  	if (err) {
> -		pr_debug("do_boot_cpu failed %d\n", err);
> +		pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu);
>  		return -EIO;
>  	}
>  

Looks good.

Acked-by: Toshi Kani <toshi.kani@xxxxxx>

I will review patch 5/5 later (probably tomorrow).
Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/