Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

[Alessandro Zummo]

On Wed, 30 Apr 2014 21:55:07 +0530
Raghavendra Ganiga <ravi23ganiga@xxxxxxxxx> wrote:

> +
> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
> +{
> +	struct ds1343_priv *priv = dev_get_drvdata(dev);
> +	unsigned int data;
> +	unsigned char alarm_mode = 0;
> +	const char *alarm_str, *diodes = "disabled", *resistors = " ";
> +
> +	regmap_read(priv->map, DS1343_CONTROL_REG, &data);

 is this thing really useful? what about having sysfs entries
 instead?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/