Re: [PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations

From: Dmitry Torokhov
Date: Wed Apr 30 2014 - 12:31:08 EST


Hi Roger,

On Wed, Apr 30, 2014 at 03:36:26PM +0300, Roger Quadros wrote:

> static int pixcir_i2c_ts_remove(struct i2c_client *client)
> @@ -198,10 +194,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client *client)
>
> tsdata->exiting = true;
> mb();
> - free_irq(client->irq, tsdata);
>
> input_unregister_device(tsdata->input);

There is no need to call input_unregister_device for managed input
devices.

> - kfree(tsdata);
>
> return 0;
> }
> --
> 1.8.3.2
>

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/