Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

From: Tomasz Stanislawski
Date: Wed Apr 30 2014 - 04:33:27 EST


Hi Rahul,
I will prepare we v3 version.
Do you want me to add your patches for exynos5?50 to the patchset?
Regards,
Tomasz Stanislawski

On 04/30/2014 08:37 AM, Rahul Sharma wrote:
> Hi Tomasz,
>
> I have tested your patches for exynos5250 and 5420. Works fine. Are
> you planning to post v3? If you want I can share hand with you for v3.
>
> Regards,
> Rahul Sharma
>
> On 9 April 2014 17:17, Andreas Oberritter <obi@xxxxxxxxxxx> wrote:
>> Hello Andrzej,
>>
>> On 09.04.2014 10:37, Andrzej Hajda wrote:
>>>> +static int exynos_phy_probe(struct platform_device *pdev)
>>>> +{
>>>> + const struct of_device_id *of_id = of_match_device(
>>>> + of_match_ptr(exynos_phy_of_match), &pdev->dev);
>>>> + const u32 *offsets = of_id->data;
>>>> + int count;
>>>> + struct device *dev = &pdev->dev;
>>>> + struct phy **phys;
>>>> + struct resource *res;
>>>> + void __iomem *regs;
>>>> + int i;
>>>> + struct phy_provider *phy_provider;
>>>> +
>>>> + /* count number of phys to create */
>>>> + for (count = 0; offsets[count] != ~0; ++count)
>>>> + ;
>>>
>>> count = ARRAY_SIZE(offsets) - 1;
>>
>> u32 *offsets is not an array.
>>
>> Regards,
>> Andreas
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/