Re: [PATCH] lib/spinlock_debug: avoid one thread can not obtain the spinlock for a long time.

[Peter Zijlstra]

On Wed, Apr 30, 2014 at 06:17:48AM +0000, Wang, Xiaoming wrote:
> Dear Peter
> 	If we wait the end of loop as loops_per_jiffy. 
> It may last more than 130s and local IRQ disabled at interval 
> which may cause Hard LOCKUP. We break out in 1 second and
> dump the stack for debug.

Yeah, so? That makes shoddy engineering alright then?

So either fix the loops_per_jiffy thing, it is supposed to wait for 1
second after all, or explain why its broken and entirely replace it.

What you do not do is make a loop with 2 differently broken timeouts and
hope one works.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/